social proof section using HTML and CSS

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Mouhib Eddine, congratulations for your new solution!

  You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code:

  To add the svg images (bottom/top) in the background, the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, see the properties below and see that the comma inside each properties declare the single modification for each svg image separated.

  body {
      background-image: url(images/bg-pattern-top-desktop.svg), url(images/bg-pattern-bottom-desktop.svg);
      background-position: left -185px top -236px, right 10px bottom -300px;
      background-repeat: no-repeat, no-repeat;
      background-attachment: fixed, fixed;
      background-size: contain, contain;
      display: flex;
      justify-content: center;
      min-height: 100vh;
      align-items: center;
      font-family: "League Spartan", sans-serif;
  }
  

  You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Mouhib Eddine Zakaria•160

  @mouhibeddinePosted about 2 years ago

  @correlucas thanks i appreciate your notes Lucas!! but i didn't get the role of the svg images that I added because I see no difference with/without them.

  0
• 

  Phúc (Scott) Nguyễn•430

  @NationsAnarchyPosted about 2 years ago

  Well done on completing the challenge, Mouhib!

  I believe that the next step we can do with this one is to implement responsive designs once the website shifts the layout to smaller screen width.

  You can have a look at the @media query CSS properties and start working from there: https://www.w3schools.com/css/css_rwd_mediaqueries.asp

  Let us know what else we can help you with, and have fun coding!

  Marked as helpful

  0