Design comparison
Solution retrospective
Struggling a lot with positioning and am still not satisfied. I would appreciate your feedback on how to improve this challenge.
Community feedback
- @visualdennissPosted over 1 year ago
I would suggest, unlike the other suggestion posted, not to focus on frameworks like bootstrap or tailwind.css, instead keep solidifying your knowledge of vanilla css, master the Grid and Flexbox and the fundamentals, then learning such frameworks can be done overnight by simply reading docs, and you can speed up your development process with such tools later on. But the more you focus on fundamentals, far you can go in the long run.
This one seems to need min-height: 100vh; on the main, but i think you already know that :) and padding-bottom: 80px; for the .wrapper could be good.
0@MadiMalikPosted over 1 year ago@visualdenniss I completely agree with your suggestion. It's important to have a strong foundation in CSS fundamentals like Grid and Flexbox before jumping into frameworks like Bootstrap or Tailwind.css. This not only helps to build a better understanding of how these frameworks work but also allows for more customization and control in your designs.
And thanks for reminding me to add min-height: 100vh; to the main element and padding-bottom: 80px; to the .wrapper
0 - @cvalencia1991Posted over 1 year ago
hi, Great Work on your project, but you should do the next things to look amazing
- implement the functionality to deploy the project on the screen, you should use Git hub Pages and set up the index
- Update the README.md to specify the type of language or frameworks are you using it
- You should delete the background of the
main
of your file (try to do this precisely to the design) - You are so advanced in this, I suggest you use different types of frameworks to adapt better a page like a tailwind or bootstrap, don't use px use, units
- Could you please, fix the accessibility issue
- Use Flex Grind to adapt the 3 info with the start to adjust that, do use marring to adapt that
Anything else is perfect, Happy Coding :)
0@MadiMalikPosted over 1 year ago@cvalencia1991 I deleted the background of the main element in my file, ensuring that it matches the design precisely.
Thank you for your suggestion. I will definitely consider using different frameworks like Tailwind or Bootstrap in the future and will use units instead of pixels for better adaptation.
Thank you for your feedback and encouragement! I will make sure to incorporate these changes and continue working towards a successful project. Happy coding to you too!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord