Social proof section using flexbox

Community feedback

• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, Iyanu Elijah Egbuwalo. I think you have done your challenge well. Here are things I have noticed on your work ~

  1. Background circle is missing.

  2. Spaces between cards don't match design. I think as long as you set justify-content property of wrapper to space-between, you can set width of each card like this. width: calc(100% - 20px);

  3. 2nd and 3rd Cards are cutted out. This is because of overflow hidden. So I hope you to remove this property and you can add padding to wrapper instead. #bottom { padding: 10px 0 20px; overflow: initial; }

  4. This is just my opinion - for header and bottom, you used id, but usually it would be better to use class for sections like them. Of course, this doesn't matter small tasks like here, but would cause issues on big projects.

  5. h1 title also doesn't match design. As long as you have decided to start career as a frontend developer, the most important thing is to have habit to work matching designs, I think.

  Hope my opinion to be helpful for your work and skill upgrades. Thank you ~

  2

  ---

  

  Iyanu Elijah Egbuwalo•145

  @enigmirePosted almost 4 years ago

  @axevldk Indeed I want to make something from coding. I will stick yo your advice, make the necessary changes and get better.

  Stick around for my next solution 😊

  Thanks

  0
• 

  Web Frog•1,840

  @MasterDev333Posted almost 4 years ago

  Hi, Iyanu. Great work so far. I have some suggestions. Background image is missing and spacings, font sizes are not exactly same as design. It would be great if you focus on making everything pixel perfect and fully responsive. And about rating-boxes and testimonial cards, I suggest you to use grid rather than flex. Grid is very good for x, y positioning elements while Flex is only for x positioning. I'd like to share my solution here. You may get some ideas from it. https://social-proof-green.vercel.app/ Hope this helps. Happy learning~

  1

  ---

  

  Iyanu Elijah Egbuwalo•145

  @enigmirePosted almost 4 years ago

  @MasterDev333 Thanks for your suggestions.

  0
• 

  T

  Grace•31,010

  @grace-snowPosted almost 4 years ago

  Hey,

  I'd echo everyone else's comments on this, it could do with getting a bit closer to the design.

  You'll probably find reducing size and line spacing helps on your h1.

  Other thing I notice is the top content needs centering when mobile landscape. I'll add a screenshot to slack so you can see what I mean.

  Happy coding! ☺

  0

  ---

  

  Iyanu Elijah Egbuwalo•145

  @enigmirePosted almost 4 years ago

  @grace-snow

  Thanks Grace

  0