Design comparison
Solution retrospective
Real beginner here, still struggling to center things and catch details with eyes only so it's far from perfect. Any suggestions to remove bad practises I may have done on this first challenge ?
Thanks for your kind feedback !
Community feedback
- @ApplePieGiraffePosted about 4 years ago
Hey, Julien PETITPIERRE!
I suggest allowing the height of the testimonial boxes to grow with their content so that none of the review text gets cut off at the bottom when the width of the viewport gets smaller.
I also suggest centering the testimonial boxes within their container in the mobile layout of the page. You can easily do that by setting
align-items
property tocenter
on their parent container.And I think a little padding below the SVG stars would create some nice space between them and the review text in the mobile layout of your page.
Otherwise, nice job! π
Keep coding (and happy coding, too)! π
2 - @dwddgszPosted about 4 years ago
Hello!
From
768px breakpoint
to something like1200px
there is no space for all stars, so they collapse. Maybe you could fix this usingmin-width:120px; display:flex;align-items:center
on.star-row
.Anyway, good job
1 - @GribichexPosted about 4 years ago
Thank you very much for your time ! I updated my submission with your recommendations ;)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord