Design comparison
Solution retrospective
Hi Devs, I completed my 3rd FM challenge. In this project, I used CSS grid to built the layout unlike the previous projects. I learnt to add multiple background image and positioning them. The area that i think should improve on is using css selectors. I have one qn. can the 5 stars can be done without duplicating the code? and do check out my project. It is responsive too. TIA, Good luck with your project.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- I believe the solution with the repeated images is correct, but you should leave the alt attribute empty for each one. Since the star icons are for decoration, and there are 15 images, screen readers will read "Image, Star" 15 times. The paragraph provides enough information about the number of stars. Personally, in this challenge, I used a pseudo-element
::beforeand placed the 5 stars as abackgroundseparated by commas.
I hope you find it useful! 😄
Happy coding!
Marked as helpful1@joelsavioPosted 11 months agoThank you @MelvinAguilar for you suggestions. I will try and implement them.
0 - I believe the solution with the repeated images is correct, but you should leave the alt attribute empty for each one. Since the star icons are for decoration, and there are 15 images, screen readers will read "Image, Star" 15 times. The paragraph provides enough information about the number of stars. Personally, in this challenge, I used a pseudo-element
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord