Design comparison
Solution retrospective
Any feedback is valuable. Used CSS Grid more in this (I am a beginner in terms of grid so suggesting better practices and techniques would be helpful). Thanks for reading.
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello DarkDev, congrats on finishing the challenge! great job with the layout
I will try to give some feedback in your grid!
On your
sections-reviews-container
, you are using Grid but you are not getting the full juice out of it, cause you are positioning the child elements usingposition: relative
andposition: absolute
!, instead of that you should increase the size of yoursections-reviews-container
maybeheight: 20rem
is a decent value, you will notice that now your grid elements scale with the grid. Now you should align each one of them on the respective position usingalign-self
, to have this working you should first remove your positions.- Lets recap, remove all the position states from your
sections-reviews-container
. - Get the width of the
sections-reviews-container
to 20rem. - Use
align-self: flex-start
onreview-card-1
,align-self: center
onreview-card-2
andalign-self: flex-end
onreview-card-3
Same result, no strange position needed, less lines of code, and all made with grid!
Hope my feedback helps you, if you have any questions, don't hesitate to ask!
Marked as helpful1@dotfivesixPosted about 2 years ago@DavidMorgade Thanks for appreciating my work. This suggestion really helped me a lot, the results are even better now and I like this approach. I even replaced relative positioning with CSS alignment in rating-cards section using
justify-self
inspired from this. So thanks a lot !1 - Lets recap, remove all the position states from your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord