Design comparison
Solution retrospective
Honestly, this challenge was the hardest so far (even if it had the 'NEWBIE' tag) especially the responsive aspect and I'm glad I'm done with it now and I would really appreciate an honest review of this solution cos I know I would really need it. Feel free to look through the code! ;)
Community feedback
- @correlucasPosted about 2 years ago
๐พHello Ayoife, congratulations for your new solution!
๐ Youโve done really good work here putting everything together, Iโve some suggestions you can consider applying to your code:
The html markup for this solution its built entirely with
<div>
and you can improve it using semantics tags to describe what its inside each block of content. You can replace the<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.2.Improve the cards giving more roundness to each card with
border-radius: 14px
:.card { margin: 0; font-size: 1rem; width: 21rem; height: 13rem; border-radius: 14px; }
โ๏ธ I hope this helps you and happy coding!
0@AyoifePosted about 2 years ago@correlucas Thanks for your feedback, I'll make those changes now
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord