Social proof section using css flex box

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To center you content to your page, add the following to your Body Element:

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.

  • The Article Element is being used incorrectly, since the testimonials are not able to stand on their own and are not independently reusable.

  Instead, you want to wrapped each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  • The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  • The .attribution needs to be wrapped in a Footer Element, to improve the semantics of your page.

  • Implement a Mobile First approach 📱 > 🖥

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Jan Toma•400

  @jantomaPosted about 2 years ago

  @vcarames Thanks for your suggestions it is very useful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @jantoma, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

  2.To add the two wave svg background images in the (top/bottom),, the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, to manage different images inside a single css property as background-image you use the comma inside each properties declare the single modification for each wave svg image separated. See the code below to see your solution with those backgrounds applied:

  body {
      background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg);
      background-position: left -185px top -236px, right 10px bottom -300px;
      background-repeat: no-repeat;
      background-attachment: fixed;
      background-size: contain, contain;
      /* background-image: url(../social-proof-section-master/images/bg-pattern-top-desktop.svg), url(../social-proof-section-master/images/bg-pattern-bottom-desktop.svg); */
      /* background-position: left top, right bottom; */
      background-repeat: no-repeat;
  }
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Jan Toma•400

  @jantomaPosted about 2 years ago

  @correlucas Thank You Lucas for your Suggestions

  0