@vanzasetia
Posted
Hi, NicoR23! 👋
Here are a few suggestions for improvements.
- Improve the alternative text by only writing the reviewer's name. You don't need to tell the person's gender unless that's related to the content. In other words, if the content is about gender then it can be useful to include the person's name. Otherwise, you don't need to do that.
- Wrap the
<p class="card__info">with<blockquote>. The quote should be wrapped by a quote element. - Don't set the
font-sizeof the page on the<html>element. You should specify the page'sfont-sizeon the<body>element. - Never use
pxunit for font sizes. Useremoreminstead. Relative units such asremandemcan adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS
I hope my suggestions help you. Have fun coding! 😄
Marked as helpful
@NicoR23
Posted
@vanzasetia Hello, thanks, I'll try to improve. One question when I want to use rem with custom values, where should I define its value in the body or in the html? I tried it with the body and the rem doesn't change, if I define it in the html the rem values change
@vanzasetia
Posted
@NicoR23
You should not change the rem value. You should just go with 1rem is equal to 16px. Although, in reality, 1rem is equal to the browser's default font size which users can change to any pixel value.
You should not set the font-size on the <html> because it can overwrite the browser's font size setting.
- Grace Snow explains the issue clearly — Should I change the default HTML font-size to 62.5%?
- The Surprising Truth About Pixels and Accessibility: should I use pixels or rems?
