Skip to content
Submitted over 1 year ago

Social proof section

NicoR23•120
@NicoR23
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social proof section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Your comment with what I should improve helps me a lot, thanks in advance

Community feedback

  • Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    Hi, NicoR23! 👋

    Here are a few suggestions for improvements.

    • Improve the alternative text by only writing the reviewer's name. You don't need to tell the person's gender unless that's related to the content. In other words, if the content is about gender then it can be useful to include the person's name. Otherwise, you don't need to do that.
    • Wrap the <p class="card__info"> with <blockquote>. The quote should be wrapped by a quote element.
    • Don't set the font-size of the page on the <html> element. You should specify the page's font-size on the <body> element.
    • Never use px unit for font sizes. Use rem or em instead. Relative units such as rem and em can adapt when the users change the browser's font size setting. Learn more — Why you should never use px to set font-size in CSS

    I hope my suggestions help you. Have fun coding! 😄

    Marked as helpful
    1
    NicoR23•120
    @NicoR23Posted over 1 year ago

    @vanzasetia Hello, thanks, I'll try to improve. One question when I want to use rem with custom values, where should I define its value in the body or in the html? I tried it with the body and the rem doesn't change, if I define it in the html the rem values ​​change

    0
    Vanza Setia•27,775
    @vanzasetiaPosted over 1 year ago

    @NicoR23

    You should not change the rem value. You should just go with 1rem is equal to 16px. Although, in reality, 1rem is equal to the browser's default font size which users can change to any pixel value.

    You should not set the font-size on the <html> because it can overwrite the browser's font size setting.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord