Social proof section

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  Hey Louis, nice work on this challenge! Don't worry too much about matching up the sizes exactly, especially when working with the JPG design files. Typically, you'd have the design files which show the values in them.

  Here are some thoughts after taking a look at your code:

  • You're loading in Google Fonts 3 separate times at the moment. It would help to remove two of them so that you're only loading it in a single time.
  • As you said, you haven't done the mobile part yet. I'd recommend spending time doing it. I'd also recommend trying to build your future projects mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users when using min-width media queries, which can be a nice performance gain.
  • Avoid using br tags to force line breaks. Instead, let the width of the containing element dictate when the line breaks. This will be especially useful when you make your site responsive.
  • You don't need alt attributes for the stars, as they add no extra context to those individual reviews. Instead, you can leave the value blank, so that screen readers skip over them.
  • You've jumped from a h1 element straight to h3 elements for the people's names in the testimonials. I'd recommend avoiding skipping heading levels unnecessarily. This can cause accessibility issues in the content hierarchy for screen reader users. So for this, the people's names would be h2 elements instead.

  I hope these tips help. Let me know if you have any questions 🙂

  0

  ---

  

  Louis Terryn•40

  @LouisterrynPosted almost 4 years ago

  @mattstuddert Thank you very much for you feedback ! I'll work on the mobile version this evening and try to apply what you said.

  Have a great day !

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  @Louisterryn you're welcome!

  0

  

  Louis Terryn•40

  @LouisterrynPosted almost 4 years ago

  Hello @mattstuddert, I've done the mobile version ad updated my code. Would it be possible for you to check it ? Thanks in advance !

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted almost 4 years ago

  @Louisterryn nice work updating your code! I'd recommend using min-width media queries instead of max-width for the reasons I mentioned above. Keep it up! As you build more projects, you'll see significant improvements in your code and how accurate you are vs the design 👍

  0

  

  Louis Terryn•40

  @LouisterrynPosted almost 4 years ago

  Thank you again @mattstuddert ! I hope to you see again in the comment section of my newt projects. Have a great evening !

  0