Design comparison
Community feedback
- @Bishalsnghd07Posted 8 months ago
Hi, Juan-Cubides👋
Congrats for completing this challenge 🎉 and you did a terrific job.
Your presence of mind in design point of view is amazing. Looks great, hands off🫡.
Just, one suggestion for you:
I would recommend work on a bit in semantic HTML. Never broke the heading levels. After using h1, then use h2 and so on. Follow the path like this 👉
h1, h2, h3, h4, h5 and h6
in ascending order always. Headings are not only use for making text bolder or darker. It can be used for maintain semantic and can be used in titles. So, work like this.Other than that good job and hope this small tip will help you in further projects also!
Once again Welcome to Frontend Mentor, wishing you a joyful journey ahead and Happy Coding ❤️
0 - @Orekihotarou-kPosted 8 months ago
Hi @Juan-Cubides.
Congratulations on completing the challenge. I love how well the mobile version turned out. Hats off to you on that ☺️.
I think you can make this even better by
-
Wrapping the
header
and thestarcontainer
in adiv
just like you did for thecontainer
row. This will facilitate aligning them side by side as the screen gets bigger. For screens that are smaller, you can useflex-direction: columnn;
-
For the
cardscontainer
, I think using a
display: flex; align-items: center;
For the bigger screen size, and on the smaller screen, changing the
flex-direction: column
will make the cards stack on top of each other.Great job on completing the challenge 🥳.
I just finished redoing the exact challenge and I even recorded my solution. You can check it out here @KimDoesCode
Happy coding
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord