Design comparison
Solution retrospective
Any feedback is welcome :)
Community feedback
- @MasterDev333Posted almost 4 years ago
Great work @Juan Carlos. Your solution is spot on. Everything is fully responsive and close to design. Next time, I suggest you use a background-image for drawing stars. Now, you used SVG tags 5 times to draw 5 stars, but if you draw 4.5 or 4.2 stars? Look forward to seeing other solutions from you. Happy coding~ :)
1@JCruz-DevPosted almost 4 years ago@MasterDev333 Thanks for the suggestion. Now I have a class "star-icon" applying the background image to display the element, so the index.html is not filled with a lot of svg elements. The changes are up, thanks for taking the time to view my solution :)
0 - @ApplePieGiraffePosted almost 4 years ago
Hey, nice work on this project, Juan Carlos! π
Your solution looks great! π
I only suggest adding a
max-width
to the content of the page in the mobile layout to prevent the content of the page from being too wide when the layout first changes from desktop to mobile, or, better yet, adding a tablet layout in between the desktop and mobile layouts if you're up for it. πKeep coding (and happy coding, too)! π
1@JCruz-DevPosted almost 4 years agoHi, thanks for the suggestion. I adjusted the layout for table, so now the elements are not too wide. Thank you for taking your time to view my solution :)
0@ApplePieGiraffePosted almost 4 years ago@juank1791
Wow, Juan Carlos! Just took another look at your updated solution, and I really like the tablet layout you addedβgreat work! π Keep it up! π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord