Design comparison
Solution retrospective
the reviews are actually overflowing, i would like to know if its a bad thing or not. Any suggestions are welcome!
Community feedback
- @correlucasPosted about 2 years ago
๐พHello @siddharth-1407, Congratulations on completing this challenge!
Great code and great solution! Iโve few suggestions for you that you can consider adding to your code:
You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the
<div>
that wraps each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Pay attention that<div>
is only a block element without meaning.โ๏ธ I hope this helps you and happy coding!
Marked as helpful0@siddharth-1407Posted about 2 years ago@correlucas Thanks Lucas, Ive a few questions though. First, is it okay to put images in <article> tag? Second, can we use <q> tag withing <blockquote> ? because i did use <blockquote> at first when i noticed that the quote font style were different, but because it didn't change the quote sign style, i searched it up and ended up using <q> which did change it.
0 - @wojocodePosted about 2 years ago
Hi! Nice work ! I recommend you to add line-height to paragraph in testimonial boxes to make more space between lines. cheers !
Marked as helpful0@siddharth-1407Posted about 2 years ago@wojocode I just fixed it thanks!! i also noticed a few other thing that were off such as the min width.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord