Social Proof Section solution

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @agnar-nomad, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  You’re in the right track I can see that you’ve used the majority semantic tags possible for this challenge, the only block you’ve missed is the paragraph containing the quote text you can improve the accessibility there using <blockquote> to indicate to screen readers that the content inside that paragraph is a quote.

  ✌️ I hope this helps you and happy coding!

  1

  ---

  

  Agnar•220

  @agnar-nomadPosted about 2 years ago

  @correlucas very true, thanks for the suggestion

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To center you content to your page, add the following to your Body Element:

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.

  • The profile images Alt Tags need to be improved. It should state the following; “Headshot of -person’s full name-“

  • To enhance the semantics of your component, you want to wrapped each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  1

  ---

  

  Agnar•220

  @agnar-nomadPosted about 2 years ago

  @vcarames No clarification needed, thank you for the suggestions!

  0