Submitted 11 months ago
Social proof section - responsive design
@Robert-Lukasz-Ksiazek
Design comparison
SolutionDesign
Solution retrospective
- What do you think about semantics in my html?
- What do you think about my CSS? Do I approach this correctly?
Thank You for your expertise.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- For star icons used decoratively, like in this challenge, it's best to keep the alt attribute empty. This prevents screen readers from repetitively reading the same description (15 times), which can be bothersome for users with visual impairments. So, you can simplify the code by leaving the alt attributes for the star icons empty
alt=""
.
-
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.If you want to learn more about the
alt
attribute, you can read this article. ๐.
- Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source ๐
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@Robert-Lukasz-KsiazekPosted 11 months ago@MelvinAguilar thank you so much for your constructive feedback.
1 - For star icons used decoratively, like in this challenge, it's best to keep the alt attribute empty. This prevents screen readers from repetitively reading the same description (15 times), which can be bothersome for users with visual impairments. So, you can simplify the code by leaving the alt attributes for the star icons empty
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord