Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
alt tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- The profile images are not decorative. Their
alt tag
should not be blank. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- The "Verified Buyer" is not a heading ❌, instead it should be wrapping in a
paragraph
element.
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
- NEVER ❌ do this as it creates accessibility issues for users and it is outdated, instead download a
px
torem
/em
converter in your code editor.
html { font-size: 62.5%; }
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0 - The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord