Design comparison
SolutionDesign
Solution retrospective
Thank you by advance for your time :)
Community feedback
- @grace-snowPosted over 3 years ago
Hi
This looks great!
Only minor changes needed are
- alt text needs redoing on all images.
alt="icon star"
should be empty alt value. That's important. It would annoy assistive tech users a lot as it is at the moment - the testimonial people images should be the person's name in alt text. That is what the pictures are of.
- with the markup you've chosen, the testimonials need some headings to give structure, so change the people's names to h2s.
Looks good otherwise, well done
1 - alt text needs redoing on all images.
- @PolThmPosted over 3 years ago
Hi you!
Thanks again for your review :)
Ok, I thought it would be nice to describe the alt icons, can you tell me why it is better to keep these values empty please?
Can I put H3 or H4 for the names of the testimonials? H2 is a bit too much, isn't it?
I will apply your other recommendations :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord