Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

social-proof-section-master

@Mostafa-ninoo

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


all feedback is welcome

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • It is best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.
  • The “star icons” serve no purpose other than to** be decorative;** They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hide them from assistive technology.

More Info:📚

https://www.w3schools.com/html/html_images_picture.asp

  • For the profile images alt tag description, it should never* include the following keywords; “image”, “photo”., “picture” and any variation of them.
    • To improve the semantics of your component, you want to wrap each individual testimonial component in a Figure element, the individuals information should be wrapped in a Figcaption element and lastly, the testimonial itself should be wrapped in a Blockquote element.

Code:

<figure>
   <figcaption></figcaption>
   <blockquote></blockquote>
</figure>

More Info:

ARTICLE

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

Marked as helpful

0

@Mostafa-ninoo

Posted

@vcarames thanks. you are always give a useful points.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord