Design comparison
Solution retrospective
Feedback appreciated!
Community feedback
- @palgrammingPosted over 3 years ago
first of all I do not know if you planned for the "attribution" section to be on the top right of the project. I like it their and I will try to standardize mine their from now on and see how it works that way it is always in the same place and out of the way.
while the design is responsive I think some fixed widths or max-widths on the elements would help the design make it like better across all screen sizes and more consistent depending on random size screens
1 - @pikapikamartPosted over 3 years ago
Good work on this one. Layout is good and the mobile state as well. @palgramming already mentioned a key point which is important. Referring to the usage of
height: 20vh
in thereview
selector.Also when going in mobile state, there is an appearance of scrollbar at the bottom. You could get rid of this by just removing the
width: 100vw
in yourbody
tag.Overall, you did a good job in here and the layout is really good^^
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord