Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Proof Section

#bem#semantic-ui
Claudio Robertoβ€’ 170

@claudio-dev1993

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I guess media queries could be better for mobile devices but i had some difficulties, you can share your tips and opinion for i improve this solution and correct any mistakes. See my code on github, Thanks!

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

Regarding your question,

Implement a mobile first approach πŸ“± > πŸ–₯. This will make things easier in ensuring that your content looks the way want it to in any screen size. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  • The β€œstar icons” serve no purpose other than to** be decorative;** They add no value. Their alt tag should left blank and have an aria-hidden=β€œtrue” to hide them from assistive technology.

More Info:πŸ“š

https://www.w3schools.com/html/html_images_picture.asp

  • To improve the semantics of your component, you want to wrap each individual testimonial component in a Figure element, the individuals information should be wrapped in a Figcaption element and lastly, the testimonial itself should be wrapped in a Blockquote element.

Code:

<figure>
   <figcaption></figcaption>
   <blockquote></blockquote>
</figure>

More Info:

ARTICLE

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!πŸŽ„πŸŽ

Marked as helpful

1

Claudio Robertoβ€’ 170

@claudio-dev1993

Posted

@vcarames Thank you for the tips! I'm learning about the mobile first approach, so I don't know how to implement it properly yet. I'll review the code and apply the other tips you recommended so thanks again!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord