Design comparison
Solution retrospective
Feedback is always welcome.
Community feedback
- @grace-snowPosted almost 4 years ago
I'm afraid alignment is still quite off from the design on this.
On mobile content is quite narrow in places and none of it is centered for me. Top is slightly to the right, bottom section is slightly to the left.
On desktop the top and bottom sections need to align at the sides like in the design.
I think all of this might come from different paddings, margins and percentage widths being used. If you just used max widths or let the grid and gap handle all that I think it would fix a lot for you.
It would also really help you if you approached these challenges mobile first. Then you wouldn't need to override styles in media queries as much.
Good luck with it
1@sanskPosted over 3 years agoThanks a lot for your comments.
Yeah, I have to adjust the margins little bit and also media queries.
I will incorporate the changes and will update it.
Thanks again.
0 - @Etang131Posted almost 4 years ago
It looks like it matches the spec to me. I would consider making the media query change happen a bit later from mobile to desktop though.
0@sanskPosted over 3 years agoThanks. I will check and update the media queries.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord