Social Proof Section - My final newbie challenge!

Community feedback

• 

  Folarin Akinloye•1,240

  @folathecoderPosted over 3 years ago

  Hi Drallas!

  Your implementation is clean and looks great. Congrats on your journey and keep it up!

  The responsiveness of the page is great on only desktop and mobile. The tablet view should not take the form of a mobile screen. Try to make that tablet more responsive or look more like a tablet by making great use of the available space. You can make the tablet layout look like the desktop, with minor tweaks!

  Also, your testimonial cards should have a min-height and not a fixed height. Declaring a fixed height will make the content inside the cards to pop out when the screen is smaller. You can test this by displaying the page on a 240px-width screen.

  A min-height will allow the content inside the card to determine the height of the card.

  .cards__item { text-align: left; height: 248px; (min-height: 248px) color:hsl(0, 0%, 100%); border-radius: 8px; background-color: var(--very-dark-magenta); margin-bottom: 1rem; }

  Just a few suggestions, I hope it helps...... Feel free to correct me if I am wrong!

  Happy Coding!

  3

  ---

  

  drallas•375

  @DrallasPosted over 3 years ago

  @folathecoder

  Thank you for your feedback, i will definitely refactor later today taking your feedback into account!

  Greetings..

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, drallas! 👋

  Just wanted to drop in to say congratulations upon completing your final newbie challenge! 🎉 It's great to hear that you had fun building it and you've done a good job! 👍

  Simply follow Fola's helpful suggestions and I think you'll be good to go! 😀

  Of course, keep coding (and happy coding, too)! 😁

  0

  ---

  

  drallas•375

  @DrallasPosted over 3 years ago

  @ApplePieGiraffe Hi APG tnx for your drop-in, I implemented most of Fola suggestions and now I'm already having fun with the next challenge :)

  0