Social proof section (Mobile First, SASS, Flexbox & Grid)
Design comparison
Solution retrospective
Hello,
Any feedback is welcome! Thank you.
Community feedback
- @zuolizhuPosted about 4 years ago
Hey Luis,
Nice job on this challenge👍!
I think you can put the
attribution
inside the<main></main>
, otherwise you will see there is a big gap between the attribution and the main. Also,margin-top: 80rem;
of the.attribution
seems too big after screen size 768 px.The comments you added make your code much easier to read! However, if you try to make
attribution
as a footer, then instead ofdiv
, usingfooter
to improve the semantic structure. You can check out this article for more 👉**semantic html**I'm looking forward to your next project😜 Happy coding 🙌!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord