Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social proof section master using HTML + CSS (FLEXBOX, GRID).

Dan 120

@Dan-raccoon-69

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi guys, I've finished the Challenge "Social proof section master". What do you think about my solution? Is there something wrong with my code? Am I using the best practices? I'd like you to give me feedback to improve please. Thanks!!!

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello @Dan-raccoon-69, Congratulations on completing this challenge!

Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

The correct size for each card is max-width: 340px so you can consider changing its value to don’t have the cards growing more than it should.

You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

✌️ I hope this helps you and happy coding!

1

Dan 120

@Dan-raccoon-69

Posted

@correlucas Thanks!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord