Design comparison
SolutionDesign
Solution retrospective
I like feedbacks, in this way i can improve my front-end abilities! feel free to give me good constructive feedback.
Community feedback
- @vanzasetiaPosted over 3 years ago
👋Hi Fadi!
👍Good job on completing this challenge! This looks good on my mobile device.
I have some feedback on this solution:
- For the person name, I recommend to use
p
instead of heading tag, since it's a title of a section. - Also for the
.text
, I recommend to useblockquote
instead of adiv
andh4
. - Use
rem
unit instead ofpx
, that way the user can control the font size based on their setting. - For the custom property name or variables name, I recommend to use lower case in this case. You don't have to follow this, but it's a common practice.
That's it! Hopefully this is helpful!
Marked as helpful0 - For the person name, I recommend to use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord