Social Proof Section Master Solution

Community feedback

• 

  Victória Nogueira Marques•390

  @victoriamnxPosted over 1 year ago

  Hi Alessandra, I saw your site and code and I have some tips:

  In the text under "10,000+ of our users love our products." you can use the <br> tag to give a line break in the text, so it aligns better, it would look like this:

  • <p>We only provide great products combined with excellent <br> customer service.

  See what our satisfied customers are<br> saying about our services.</p>

  In the background images of the site you can align them better, looking like this:

  • body { background: url(components/images/bg-pattern-top-mobile.svg), url(components/images/bg-pattern-bottom-desktop.svg) hsl(0, 0%, 100%); background-repeat: no-repeat; background-position: top left, bottom right; }
  • and passes the z-index property in your container where the other elements are

  and you can also review the desktop css, as the rate boxes are a little bit bigger than they should be

  I hope the tips help, you understood the details very well and the result is great :)

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/icon-star.svg" alt="Star">
  
  <img src="images/icon-star.svg" alt="">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Josh•1,110

  @josh76543210Posted over 1 year ago

  Hi @itsale-o,

  Great job on your solution. Looks good!

  One recommendation that I have for you is to add a max-width to your container. This is generally a good practice because it will contain your content on larger screen sizes instead of everything being stretched across the whole page. Something like:

  #container {
    max-width: 1000px;
  }
  

  Also, if you haven't already, I would recommend looking into using css grid. You did a great job using flexbox here but I think it would be better to use css grid. The reason being that you just have one grid to manage instead of multiple flexbox rows. If you are interested, here is a really good tutorial for learning css grid: https://www.youtube.com/watch?v=0xMQfnTU6oo

  Keep up the good work and happy coding!

  Marked as helpful

  0