Social proof section master solution

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello again Faruk, congratulations for your new solution!

  😎 I saw your preview site and I liked a lot the work you’ve done here, it's almost complete, I’ve some suggestions you can consider applying to your code:

  You've inserted only one background (the top one). Here's how you can add both.To add the two wave svg background images in the (top/bottom),, the best way is by using background-image to manage it since adding them to the body you make sure it will be under everything, to manage different images inside a single css property as background-image you use the comma inside each properties declare the single modification for each circle separated. See the code below to see your solution with those backgrounds applied:

  body {
      background-image: url(./images/bg-pattern-top-desktop.svg), url(./images/bg-pattern-bottom-desktop.svg);
      background-position: left -185px top -236px, right 10px bottom -300px;
      background-repeat: no-repeat, no-repeat;
      background-attachment: fixed, fixed;
      background-size: contain, contain;
      font-family: var(--ff-primary);
      /* background-image: url(./images/bg-pattern-top-desktop.svg); */
      background-repeat: no-repeat;
      font-size: 15px;
  }
  

  2.You did a really good work here putting everything together, something you can improve its your code html markup and semantics. You can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Faruk Ahmad•150

  @farukwebcode21Posted about 2 years ago

  @correlucas i am really happy for your suggestion , thank for suggestion, this suggestion is very helpful for me

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi,

  Nice job on the desktop part of the challenge, mobile just needs a bit of work. You can the following media.

  @media (max-width: 768px) {
  .rating_card {
      flex-direction: column;
      gap: 20px;
  }
  
  .top-section {
      display: block;
  }
  
  .ratings > div, .rating_card > div {
      margin: 0;
  }
  
  .card {
      width: auto;
  }
  
  }
  

  The above will make all the elements stack. Hope you find this help, let me know if you have any other questions.

  Marked as helpful

  0

  ---

  

  Faruk Ahmad•150

  @farukwebcode21Posted about 2 years ago

  @hyrongennike Thanks for your suggestion

  0

  

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  @farukwebcode21 no problem

  0