Design comparison
Solution retrospective
This challenge is very good, it made me search many things on the internet. I think I use many div and I think there must be a way to repeat the Img of the star easier but I didn't find it.
I appreciate your suggestions
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
It is best practice to use, Classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.
-
To properly center your content to your page, you will want to add the following to your Body Element (this method uses CSS Grid):
body { min-height: 100vh; display: grid; place-content: center; }
-
Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.
-
The profile images are not decorative. Their Alt Tags should not be blank. It should state the following; “Headshot of -person’s full name-“
-
To improve the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0 -
- @luiis-fuenmayorPosted about 2 years ago
wow that's a lot of room for improvement on my part, thank you very much for your time and suggestions
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord