Design comparison
Solution retrospective
I got a ton of HTML issues because of the stars. Anyways mentors, help me get better!
Community feedback
- @BurritoDoggiePosted over 3 years ago
Hello Tesla-amassador,
Great to see another one of your challenges! I really like that you changed the text to be thinner rather than 'fat' or big. I think the way you did it looks better.
Keep Coding!
(@@) \__/
2@tesla-ambassadorPosted over 3 years ago@BurritoDoggie Thank you soo much for this feedback!
0 - @ApplePieGiraffePosted over 3 years ago
Hi there, Tesla_Ambassador! π
Nice to see you complete another challenge! π Good job on this one! π
A few things I'd like to suggest are,
- Centering the content of the page when the layout switches from desktop to tablet/mobile (currently, things are pushed to the left of the page a bit).
- Adding a heading to the testimonial cards (you could just turn the titles of the cards into headings, I think) to get rid of those errors on your solution report (every
<article>
tag you use should have a heading inside it to identify it). - Perhaps not using percentage values for margin/padding. I find them a little harder to work with because it makes the space in certain places of the design difficult to predict on different screen sizes and fixed values for margin/padding often work well/maybe even slightly better oftentimes. π
Keep coding (and happy coding, too)! π
2@tesla-ambassadorPosted over 3 years ago@ApplePieGiraffe I noticed they were pushed to the left, I'm still working on it. I actually got 74 HTML errors hahaha, because of the Alt attribute. But I worked on it! So I guess I have to change the titles of the articles to headers. Let me try to work on the padding π. Happy coding (and Keep on coding too!)
2@ApplePieGiraffePosted over 3 years ago@tesla-ambassador
Awesome! π Keep on going! π
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord