Design comparison
Solution retrospective
Hey guys, this is my first time using SASS. Feel free to let me know if I'm doing something wrong. Happy coding!
Community feedback
- @brookewargnierPosted about 3 years ago
Really great job focusing on making the content more responsive.
One really quick tip that I just had to learn the hard way! Be careful using vh and vw, especially when it comes to text. With text, it can start to get really wonky, or way tooo small to read when you rely on vw and vh as your calculator.
Another issue I've found with vw is when you get to scrolling content, you're items will not center properly, and you'll be stuck with a scroll horizontally as well. Its a major pain. I'd set widths to 100% instead.
I'd also let your media queries, grids, and flex boxes take care of making the layout responsive and set breakpoints for your text to adapt that way.
Marked as helpful0@snVladkovPosted about 3 years ago@brookewargnier Thank you for your feedback Brooke.
You're right about the font sizing units. I wanted to boost responsivness, however, I only ended up writing more code in my media queries. In the future I'll stick to more common units like ems, rems or pxs.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord