Design comparison
SolutionDesign
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The background images need to be applied using CSS not HMTL. You will accomplish this using the
background-image
property.
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “stars” to fully remove them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The profile images
alt tags
need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:📚
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
0@VCaramesPosted almost 2 years ago- Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant 👑way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.
More Info: 📚
- The web development process can be made easier and expedite the process by implementing a
CSS Reset
.
Here are some examples that you can freely use:
0 - The background images need to be applied using CSS not HMTL. You will accomplish this using the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord