Design comparison
Solution retrospective
had a good time building this project, great stuff.
Still improving on the positioning and images.
Trying to do one project per day.
I am open to suggestions on how to improve my code!
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The background images should be applied using CSS not HTML. You can accomplish this by using the
background-image
property. -
The profile images are not decorative. They need to haveAlt Tags; It should state the following; “Headshot of -person’s full name-“
-
To enhance the semantics of your component, you want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0 -
- @AdrianoEscarabotePosted about 2 years ago
Hi joaovitorwitt, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
Images must have
alt
text, unless it is a decorative image, for any decorative image each img must have analt=""
and addaria-hidden="true"
to make all assistive web technologies, such as screen readers for example.Learn the differences between decorative/meaningless images vs important content.
a project a day is a way to practice something new that you are learning, I recently did a personal challenge that was 7 projects in a week! I recommend you look at my profile to cheer up!
The rest is great!
I hope it helps... 👍
Marked as helpful0@joaovitorwittPosted about 2 years ago@AdrianoEscarabote Thank you so much for the feedback.
i will certainly improve on that for my next project.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord