@evanhill1989
Posted
Good job!
This one was deceptively difficult for me, and I ended up with some similar visual incongruencies as you did with the original design.
Small stuff really, but for example, I couldn't get the star review containers to be the exact same width either. I expected flex would be able to take care of it, but my code started sprawling so much I couldn't find an efficient way back to getting the stars to align consistently in the stair step pattern with the box below it.
It seems using padding, gap, margin etc. to create proper alignment it might also be creating some responsiveness problems on more complex designs.
The more I rely on gaps, padding, and margin in child elements the more I end up having to use them to keep things looking right, and the more unpredictable the flex behavior becomes. In my next projects I will make more effort to get proper alignment without using as many shortcuts if I can.
Are you feeling the same?
@littygabby
Posted
@evanhill1989 thank you for your feedback.
Yes, this gave me a hard time, I was having problem with the stars too.
What I did was to use the margin, padding and gap on it differently depending on the device width.
I don't know if that's a good practice but since it solve the problem at hand now, I'm a bit relieve but I think it's a great way to improve and look for best practice as we continue to learn.
Oh hey, @evanhill1989 would you mind connecting with me outside frontendmentor so we can build a more personal relationship. If this is okay with you, my twitter and telegram @littygabby
@littygabby
Posted
@evanhill1989 thank you for your feedback.
Yes, this gave me a hard time, I was having problem with the stars too.
What I did was to use the margin, padding and gap on it differently depending on the device width.
I don't know if that's a good practice but since it solve the problem at hand now, I'm a bit relieve but I think it's a great way to improve and look for best practice as we continue to learn.
Oh hey, @evanhill1989 would you mind connecting with me outside frontendmentor so we can build a more personal relationship. If this is okay with you, my twitter and telegram @littygabby
