Skip to content
Submitted about 3 years ago

Social proof section | HTML CSS Sass

Pop Andrei•120
@pccipri
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social proof section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

👋Hello there👋 Just finished this challenge and it took a bit longer than the rest but I think it's okaish. Anyway if u have any advice on responsiveness or just an opinion of my code and how it can be improved let me know. Thank you for taking your time to read this.Have a great day!

Community feedback

  • Ken•4,915
    @kens-visualsPosted about 3 years ago

    Hey @pccipri 👋🏻

    I have some suggestions to help you fix the accessibility and HTML issues.

    • Pretty much every <img> tag in this project, besides user profile pictures, should have aria-hidden="true". Like, the following examples:
    <img class="bg-top-image-desktop" src="images/bg-pattern-top-desktop.svg" aria-hidden="true">
<img src="images/icon-star.svg" aria-hidden="true">

    this should fix all the accessibility and HTML issues. Don't forget to generate a new repot once you fix the issues.

    • One small suggestion would be to add some padding to star review boxes.

    I hope this was helpful 👨🏻‍💻 overall, you did a nice job, it looks pretty good on mobile viewport width. Cheers 👾

    Marked as helpful
    1
    Pop Andrei•120
    @pccipriPosted about 3 years ago

    @kens-visuals Thanks a lot for the review and the ideas.

    0
    Ken•4,915
    @kens-visualsPosted about 3 years ago

    @pccipri you're welcome 😇

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord