Social Proof Section HTML + CSS

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @orandorisk, well done on this challenge! I've noticed a few things that could be improved.

  • The bottom padding on your cards completely disappears at certain widths, for example on ipad Pro. That's because they have a fixed height - I'd say let your content + padding decide the container height, they look perfectly fine when this is unchecked in dev tools.

  • All your cards have one class name in common. You can make use of that by defining all styles shared by each card under that one class name .testimoni, instead of .testimoni.sat, .testimoni.du, .testimoni.tig all together. That way, if you want to change, say, a background color to the middle card, it will be very easy to keep the rest of the styles intact. Does this make sense? If that was your conscious decision though then that's okay!

  • I think those background images should be set as background-image in your CSS (probably on pseudoelements) instead of being placed in the HTML, as they don't really add content to the page. And if you prefer to have them as they are, I would leave the alt attribute empty alt="" (but don't remove it completely).

  Hope this helps!

  1

  ---

  

  orlandoriski•95

  @orandoriskPosted over 3 years ago

  wow this feedback so impressive for me, thanks @AgataLiberska I will make other code with your advice

  0

  

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  @orandorisk No worries, happy to help! You don't need to start from scratch though, learning to improve existing code is important, too! :)

  0