Design comparison
Solution retrospective
Hi all! Thanks for checking out my project. If you have any advice on responsive design, please leave a comment. Thank you and happy coding!
Community feedback
- @iwaskoreanPosted over 3 years ago
안녕하세요!! 여기서 한국분은 처음 뵙는거 같네요 ㅠㅠ 위에분 댓글처럼 태블릿 사이즈 디자인만 보완하면 완벽할거같아요 👍
저도 맨처음에 깃허브에 프로젝트마다 하나하나 리포지토리 만들어서 했는데 나중에 되니까 리포지토리가 너무 많아지더라구요. 개인적으로 Newbie나 Junior 레벨은 DIFFICULTY별로 하나씩만 리포 만들어서 그 리포에 프로젝트 디렉토리별로 나눠서 올리는게 더 나은거 같아요.
잘 보고 가요 ~!!
0@creativehkimPosted over 3 years ago@SewookHan 안녕하세요! 댓글 넘넘 감사합니다 :) 저도 한국분 뵙게 되니 반갑네요 ㅎㅎ 저도 그 생각하고 있었는데 그렇게 하려면 깃허브에서 리포 새로 만들고 그냥 업로드하면 될까욤? 프로젝트 일일이 링크 다 바꿔야되겠죠?ㅠㅠ
조언 감사해요!
0 - @RayaneBengaouiPosted over 3 years ago
안녕하세요 Hyunji Kim,
First of all, congrats for the challenge !
I don't know if the problem is on my side, but your link to the challenge page redirect me on another challenge (ping challenge), so I checked your code directly on Github.
Your solution looks good and responsive for desktop and mobile. However, the transition with the tablet size could be improved. I think by removing the width and margins on your main
section
and addingtext-align : center
with some padding would be great.But there are various ways of doing it so it depends on what people prefer and your design preferences !
Overall, well done for the challenge and happy coding ! 😃
0@creativehkimPosted over 3 years ago@RayaneBengaoui 안녕하세요 Rayane! Thank you for your comment. I am still learning git and I sort of messed up with the github repo... lol I noticed just now and updated it to a new link. I could definitely add tablet size responsive code to this.
Thanks a bunch! :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord