social-proof-section-master

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your stars to fully remove it from assistive technology.

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The profile images are not decorative. They need to haveAlt Tags; It should state the following; “Headshot of -person’s full name-“

  • The article element is not the best choice for wrapping these testimonials. In order to use the article element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site).

  You instead, want to wrap each individual testimonial component in a Figure element, the individuals information should be wrapped in a Figcaption element and lastly, the testimonial itself should be wrapped in a Blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Oluwatobi•160

  @Oluwatobi9034Posted almost 2 years ago

  @vcarames Thank you very much for your feedback. I really do appreciate.

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Oluwatobi9034

  Glad I could help!

  Keep it up!

  0

  

  Oluwatobi•160

  @Oluwatobi9034Posted almost 2 years ago

  Hello @vcarames, can I add both the property aria-hidden and alt attribute ?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Oluwatobi9034

  For images that are solely decorative, yes.

  The alt would be left blank (alt="")

  1

  

  Oluwatobi•160

  @Oluwatobi9034Posted almost 2 years ago

  @vcarames okay, thanks.

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Nice solution 🤩

  To improve the code there are several tips on how you can use an alt attribute for images. If the image is just for decoration you can still write an alt attribute but leave it empty, such images don’t need any alt tag but you will need to also add aria-hidden=“true”. Otherwise, you need to use an alt tag to describe the image for accessibility.

  According to MDN “The alt attribute holds a text description of the image, which isn't mandatory but is incredibly useful for accessibility — screen readers read this description out to their users so they know what the image means. Alt text is also displayed on the page if the image can't be loaded for some reason: for example, network errors, content blocking, or linkrot.“

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  Marked as helpful

  0

  ---

  

  Oluwatobi•160

  @Oluwatobi9034Posted almost 2 years ago

  @catherineisonline thank you so much for your feedback. I really do appreciate.

  0