Design comparison
Solution retrospective
You think you can find inefficient code in my repository? let me know!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Your HTML should have a
main
element that will assist in identifying the main content of your site. In this, case themain
element would be wrapping the entire component.
More Info:📚
- The profile images
Alt Tags
need to be improved. It should state the following; “Headshot of -person’s full name-“
More Info:📚
- For the testimonials, it is best to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@rafdidactPosted almost 2 years agoHey! I really appreciate your suggestions. Seems like I gotta work on my use of semantics.
I have a question, should I use a
main
tag even though my HTML code doesn't follow a conventional webpage structure? Because I didn't wrapped all my content inside of amain
element because I thought this was kind of pointless if I wasn't going to use anyheader
and/orfooter
elements as well.1@VCaramesPosted almost 2 years ago@rafdidact
Glad I could help!☃️
For this challenge, it is meant to be part of a much larger site, as the name of the challenge implies.
I didn’t mention it, since the report stated it, but there is a
footer
; theattribution
. (If you haven’t gotten a chance to read the report, I highly suggest you do, as it includes valuable information)While there may not be a
header
there still a there is a still a single section, which ultimately is the main content of your site.Pretty much everything you build will have a
main
element, regardless of how small a component it is.Hopefully, that clears things up.
Keep it up!
1 - Your HTML should have a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord