Social proof section | FLEXBOX

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, good job, Dwight! 👏

  Your solution looks good and it's responsive, too! (And I see you managed to position the background SVGs. 😆)

  I only suggest,

  • If you are to break into a mobile-friendly layout rather quickly (1285px in your solution), setting a max-width on the review boxes containing the SVG stars and the testimonial boxes might be a good idea to prevent them from appearing too wide when the layout first changes.

  Keep coding (and happy coding, too)! 😁

  1
• 

  Faruq Sadiq•350

  @PhrukeyPosted about 4 years ago

  Hi SarsiPC, I'm glad you fixed the background issue. I think a background-size: cover should also work in this case. Cheers

  1

  ---

  

  Dwight•215

  @SarsiPCPosted about 4 years ago

  @Phrukey That would work if the background was one piece. But in this solution, 2 parts of the background was given. You had to place them in the corners.

  0

  

  luwa•325

  @luwa-starPosted about 4 years ago

  @SarsiPC Actually, you can. Just add it to the background shorthand for both SVGs but you'd have to consider how it would look.

  0
• 

  luwa•325

  @luwa-starPosted about 4 years ago

  Great job! It looks really nice.

  However, it looks nice on specific screens. I suggest you make better use of the media queries. If you choose to only consider the screen sizes in the style-guide.md . Your design won't be responsive on other screen sizes. Instead of using max-width:1280px try going for min-width:1280px. Also, choose a suitable min-width for medium screen sizes.

  Secondly, for screen sizes with width less than 320px there's an offset. I suggest you check that out it might be that you are using the wrong unit or there's an extra padding somewhere. You need to check it out. Btw I don't really understand why you are using min and max within the same class. Is it that there's a concept behind it? From what I know CSS interprets code in order. Don't be offended, I genuinely don't know.

  0