Design comparison
Solution retrospective
I Created This In Just 3-4 Hours, Would Love To Hear Feedback From You All.
Have a look on the output :)
Community feedback
- @MojtabaMosaviPosted almost 3 years ago
1- Put a mix-width on you contaienr so it doesn't get to big on large screens, above 1400px it begin to uglify the layout the layout because there everything grows bigger and there is to much empty space on the page.
2- The way you implemented ratings is just fine but since the pictures are merely decorative you could use css background property which simpifies the markup alot.
3- For the testimonials I would do something like:
<div class="testimonial"> <div class="testimonial__profile> <img class="testimonial__avatar></img> <div class="testimonial__user"> <span class="testimonial__name></span> <span class="testimonial__status></span> </div> <blockqoute class="testimonial__review"</blockqoute> </div>
Keep coding :=)
0@sparshcodesPosted almost 3 years ago@MojtabaMosavi Hey :) Thanks a lot for the feedback. And I had already used max-width of 1440px on container that is containing all the elements.
2- i also tried the background-image approach, but atlast i decided to use img elements since it was easy to give spacing between them.
3- Yeah , i will update the layout and will use block quote
Thanks a lot again for the feedback, appreciate it a lot :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord