social-proof-section

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “star icons” serve no purpose other than to** be decorative;** They add no value. Their alt tag should left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  [MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <blockquote></blockquote>
     <figcaption></figcaption>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • Your CSS Reset is being underutilized. 😢 To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • Implement a Mobile First approach 📱 > 🖥

  Mobile devices are now the dominant 👑 way in which people browse the web. Making it critical that your website/content looks perfect on all mobile devices.

  More Info: 📚

  Mobile First

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  lamy•150

  @Lamy237Posted almost 2 years ago

  Hi @vcarames,

  Thank you for your feedback.

  Didn't know much about aria attributes. For the reset, I prefer to add only styles I will absolutely need (just a personal preference).

  For the mobile first, I guess I need to train more on that one. Somehow, I feel more comfortable with styling for desktop first, as the remaining styles will be mush easier.

  0