@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The profile images are not decorative. Their
alt tag
should not be blank. It should state the following; “Person’s full name-“
More Info:📚
- For the testimonials, it is best ✅ to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure>
<blockquote></blockquote>
<figcaption></figcaption>
</figure>
More Info:📚
- Your
CSS Reset
is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it. Here are some examples that you can freely use 😁: Josh Comeau Reset Eric Meyer Reset
- Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect 💯 on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice ✅ to use
em
formedia-queries
. Using this unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
@matthew-marco
Posted
@vcarames but why should I use figure and blockquote it is the first time I hear about them and idk what they use for also the css reset is like the normalize right and next time I will use em and write more media-queries thx
@VCarames
Posted
@matthew-marco
- Semantics; giving your code structure and meaning
- Correct
- ✅