Design comparison
Solution retrospective
how do I complete the rest of the background? I can only add 1 svg without breaking the whole background.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Along with the blank
Alt Tag
, you also want to include thearia-hidden=“true”
to your “stars” to fully remove them from assistive technology.
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The profile images are not decorative. They need to have
alt tags
It should state the following; “Headshot of -person’s full name-“
More Info:📚
- For the testimonials, it is best to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - Along with the blank
- @HassiaiPosted almost 2 years ago
Replace <section class="container"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. Add alt attribute to all the <img> to fix the error issues. alt= " ", the value for alt is the description of the image. for more on semantic html visit https://web.dev/learn/html/semantic-html/
Give the body two background-images , background-repeat no-repeat , background-position to position the images . e.g: background-image: url(), url() ; background-repeat; background-position: to left ( this is the position of the first image) bottom right( this is the position of the second-image).
Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To
Hope am helpful. Happy Coding
0 - @XxtbmfxXPosted almost 2 years ago
You can use z-index and position absolute.
you could put images in a div (1 each and then position it so it fits the design ) https://www.w3schools.com/cssref/pr_pos_z-index.php
Also: you could add a description text to the image https://www.w3schools.com/howto/howto_css_image_responsive.asp
The rest looks good, remember to add the color to the text, I add the color variables so i can use them more easily
Continue Practicing :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord