Social proof section developed with ReactJS and SCSS

Community feedback

• 

  P

  David Rodriguez B.•430

  @davidFreelance19Posted about 2 years ago

  Hello developer. I want to congratulate you on the good job you just did!

  Regarding your comment, I would recommend that you do some research and learn a bit more about the properties of display flex and display grid . Within these themes, there are positions by group and by element. An alternative that could solve the positioning of the star and testimonial divs is to apply an align-self to each element and tell it if it is going to have an align-self: start, align-self: center or align-self: end and with this alternative it would be aligning the elements with respect to the parent div (This way is a better practice than applying a transform)

  Believe me that by mastering these themes you will already have 50% mastered CSS

  David Rodriguez

  Marked as helpful

  1

  ---

  

  Santiago Moraga Caldera•710

  @Remy349Posted about 2 years ago

  @davidFreelance19 Really, thank you very much for your advice. I will learn a better use of flex and grid, I feel that at the moment my skills with both are basic, I will investigate to increase my level. Again, thank you very much.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The background images are missing from the component.

  • The profile images are not decorative. Their Alt Tags should not be blank. It should state the following; “Headshot of -person’s full name-“

  • The Article Element is not the best choice for wrapping these testimonials. In order to use the Article Element the component needs to be able to make sense on its own and be independently distributable (can be used in on another site). These testimonials cannot do neither.

  You instead, want to wrap each individual testimonial component in a Figure Element, the individuals information should be wrapped in a Figcaption Element and lastly, the testimonial itself should be wrapped in a Blockquote Element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:

  ARTICLE

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  0