Submitted almost 2 years ago
My Social Proof Section Solution Using Flexbox & Grid
@lindabgaa
Design comparison
SolutionDesign
Solution retrospective
No particular question but I'm open to any suggestions to improve my code ! π
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- Along with the blank
alt tag
, you also want to include thearia-hidden=βtrueβ
to your βstarsβ to fully remove them from assistive technology.
More Info:π
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- The profile images are not decorative. Their
alt tag
should not be blank. It should state the following; βHeadshot of -personβs full name-β
More Info:π
- For the testimonials, it is best β
to to wrap each individual testimonial component in a
figure
element, the individuals information should be wrapped in afigcaption
element and lastly, the testimonial itself should be wrapped in ablockquote
element.
Code:
<figure> <blockquote></blockquote> <figcaption></figcaption> </figure>
More Info:π
- For improved accessibility π for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πππͺ
Marked as helpful1 - Along with the blank
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord