social-proof-section-master

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • ⚠️ Remove the header element, it is beings used incorrectly ❌.

  • The profile images are not decorative. Their alt tag should not be blank. It should state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  • For the testimonials, it is best ✅ to to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <blockquote></blockquote>
     <figcaption></figcaption>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  • Your CSS Reset is being underutilized. 😢 To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  1

  ---

  

  Rachid•190

  @Rachid02elhaidiPosted almost 2 years ago

  @vcarames thanks a lot, i used to add css normalize file , but i forgot to add it here

  1