Social Proof Section Challenge using HTML and CSS.
Design comparison
Solution retrospective
Hi All,
Here to make new friends, collaborate, and grow. Feedbacks and suggestions are most welcome. Good Day!
Community feedback
- @RayaneBengaouiPosted over 3 years ago
Hello Nainpreet Singh,
Congrats for completing the challenge ! It looks pretty close to the design 😁
I'd like to suggest :
-
Don't use % on your
border-radius
as they will extend/shrink based on their parent size. So here, using px/rem/rem would be better. -
Add
border-radius
to your.rating
classes to get closer to the design. -
Use more generic classes for styling. For example, you have
rating-one
,rating-two
andrating-three
that inherit from the same background-color, width and margins so you could define a classrating
that holds all those properties and then make sub-classes for specific properties. Seems like you did it correctly for the cards part 😉. -
Take a look at HTML semantic tags. Instead of using only
div
there are plenty of tags that will make your code more explicit. -
Try to tackle the tablet/mobile version with media queries
Overall, well done for the challenge and happy coding ! 😃
0@nainpreet-05Posted over 3 years ago@RayaneBengaoui Thanks a lot for your inputs. These are really going to help in code optimization and increasing the accuracy of the design. Happy Coding !
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord