Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Proof Section

Taha 310

@thaykrgl

Desktop design screenshot for the Social proof section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would be very happy if you could help me with the parts I need to improve. Thank you for your feedback.

Community feedback

@Tielinen

Posted

Hi Taha, Good work.

You captured design well. Your code is short, effective and easy to read.

Few minor details, I would,

  1. focus more about responsiveness to make sure that the page looks the way I want also between breaking points, for example in tablets.

  2. change class naming convention, more general, "font-700" to "main-weight". If the design is adjusted later, you don't need to change the HTML, just a value in CSS.

  3. keep styling altogether away from HTML, by naming classes about what they are. For example"main-heading. "card-heading" and then style them in CSS, example:

.content,
.rate,
.name {
  font-weight: 700;
}

Like mentioned before, these are just minor details. For my eye goof quality code. Keep on coding, you are getting good at this.

Best wishes Janne

1

Taha 310

@thaykrgl

Posted

@Tielinen Thank you very much for your suggestions. They are very important to me.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord