Design comparison
SolutionDesign
Solution retrospective
I started with the mobile version and used the media query for desktop version. I used margin left and top for the reviews in the desktop version. What could I do to improve my code? Do you have some tips on accessibility to implement on my code?
Community feedback
- @ApplePieGiraffePosted almost 2 years ago
Hey, mbedon! π
Nice work on this challenge! π
A few things I suggest are,
- Setting the
alt
text for the star icons in the ratings section to be an empty string so that they won't be read out by screen readers. Thatβs because those elements aren't necessary for the content of the page and as a result doesnβt need to be read by screen readers. It can also be tiresome to hear the screen reader read out thealt
text for each individual star icon! - I would do the same thing for the avatars in the testimonials section unless you can add some more descriptive
alt
text to them that is more meaningful to the user. - For the ratings section, I would use flexbox to lay out those ratings boxes in a column and then shift the second and third boxes to the right using margin-left or the transform property. π
- Adding a favicon to the site. There should be one in the starter files for this challenge that you can use.
Hope you find this helpful. π
Keep coding (and happy coding, too)! π
0 - Setting the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord