Design comparison
SolutionDesign
Solution retrospective
Hello, Please help me to improve my code be your comment and point of view
Community feedback
- @tedikoPosted over 3 years ago
Hello, Ramy Ibrahim Fawzy! 👋
Congratulations on finishing another challenge! You did good on this challenge. I would suggest you to:
- Change the
alt
attributes for the avatar images, as they don't add any extra context for screen reader users. Since your images are decorative youralt
text should be provided empty (alt="") so that they can be ignored by assistive technologies. - Try to work on the proper class naming. Your classes aren't descriptive and also hard to read in the code. One of many benefits of proper class naming is that you know what to expect from a certain class without looking at code, even if you aren’t the person who created it or if it was written a long time ago. The name of a selector should be self-descriptive and readable. For example
.top-section
can be your.intro
,.right
div can be your.ratings
,.bottom-section
can be.testimonials
etc. - Add
max-width: 1110px
to your.container
on desktop, so your page content doesn't stretch too much on higher resolutions than 1440px. Good luck with that, have fun coding! 💪
0@RamyEbrahimPosted over 3 years agoHello tediko, l'd like to thank you for your comment to help me, and l'll take care in the coming designs to do all your valued suggestions , thanks again for your help. appreciated
0 - Change the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord